Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility problem with symfony-maker bundle #340

Closed
crevillo opened this issue Sep 10, 2018 · 3 comments
Closed

Compatibility problem with symfony-maker bundle #340

crevillo opened this issue Sep 10, 2018 · 3 comments
Labels

Comments

@crevillo
Copy link

Hello, i'm using phpdox for some of my projects. In the last one i'm trying to add it, i'm using symfony 4.1. problem is i have a deps issue. here's the output of my composer command...

composer require --dev theseer/phpdox
Using version ^0.11.2 for theseer/phpdox
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for theseer/phpdox ^0.11.2 -> satisfiable by theseer/phpdox[0.11.2].
    - Conclusion: don't install nikic/php-parser v4.0.3
    - theseer/phpdox 0.11.2 requires nikic/php-parser ^3.1 -> satisfiable by nikic/php-parser[v3.1.0, v3.1.1, v3.1.2, v3.1.3, v3.1.4, v3.1.5].
    - Can only install one of: nikic/php-parser[v3.1.0, v4.0.3].
    - Can only install one of: nikic/php-parser[v3.1.1, v4.0.3].
    - Can only install one of: nikic/php-parser[v3.1.2, v4.0.3].
    - Can only install one of: nikic/php-parser[v3.1.3, v4.0.3].
    - Can only install one of: nikic/php-parser[v3.1.4, v4.0.3].
    - Can only install one of: nikic/php-parser[v3.1.5, v4.0.3].
    - Installation request for nikic/php-parser (locked at v4.0.3) -> satisfiable by nikic/php-parser[v4.0.3].

This php-parser requirement comes from the symfony/maker-bundle package which we need too.
https://github.com/symfony/maker-bundle/blob/v1.7.0/composer.json#L17

So, the question. would it be possible to add nikic/php-parser 4 also in the composer?
i can make a pr if you want.

thanks.

@theseer
Copy link
Owner

theseer commented Sep 10, 2018

Thanks for the the report.

PHP-Parser 4 requires PHP 7 and that in turn would require to raise the minimum PHP version of phpDox. So for now, that is sadly a won't fix.

For details on this check #328.

@crevillo
Copy link
Author

not even telling composer to allow it to download php-parser 4 and also php-parser 3.1?
like in https://github.com/crevillo/phpdox/blob/master/composer.json#L27

thanks.

@theseer
Copy link
Owner

theseer commented Sep 10, 2018

As is allowed for a major version, the API changed between 3.x and 4.x.

I admit I didn't verify if phpDox would be affected but the list of changes is quite long according to the Upgrading guide of PHP-Parser.

Again, tools should not be installed via composer.

@theseer theseer closed this as completed Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants