Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install phpdox on a symfony environnement #328

Closed
jframos0 opened this issue Mar 13, 2018 · 2 comments
Closed

Can't install phpdox on a symfony environnement #328

jframos0 opened this issue Mar 13, 2018 · 2 comments

Comments

@jframos0
Copy link

Hi,

I work on Symfony 3.4, with phpUnit 7.0.0 and php-timer 2.0.0. I would try phpdox on my project but i have this problem with composer require.

image

@jframos0 jframos0 changed the title Can't install phpdox on my symfony environnement Can't install phpdox on a symfony environnement Mar 13, 2018
@theseer
Copy link
Owner

theseer commented Mar 13, 2018

Hi,

thanks for the bug report.

tl;dr: Tools should not be installed via composer. Use the phar version of phpdox and consider using phive to install it.

Longer version:
Mixing dependencies of the application runtime with development and tool needs is a very bad idea. Mixing the requirements of different tools is inherently worse. The result of this can be seen with the problem you just reported. To make things even worse, there is no easy fix here: To use php-timer 2.0 as phpunit 7 requires, phpdox would need to get updated to also use php-timer 2.0.x. While that itself is a trivial change, php-timer 2 does require PHP 7.1+ while phpDox (currently) still supports php 5.6+. Since the API and namespace changed, there is no trivial change here unless i'd provide a compat layer. A lot of effort to simply get a time ;) and only until phpDox' php requirement will get raised.

Other than with the newest versions of PHPUnit, my goal is to support every PHP-Version that at least still gets security fixes from the PHP Project. So for now, that means PHP 5.6 needs to be supported until the end of 2018.

Again, to quote my tl;dr, installing phpunit as well as phpdox or any other tool for that matter as their respective phar would make that problem go away and as another benefit would wipe all the crap you don't need for your project at runtime from the vendors folder.

@jframos0
Copy link
Author

Ok i think i understood, thank you for your reply.

I close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants