add scaling to <iframe>s in the preview list so all content can be seen
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for awesome-bhaskara-b7d76c ready! 🔨 Explore the source changes: 8c158b0 🔍 Inspect the deploy log: https://app.netlify.com/sites/awesome-bhaskara-b7d76c/deploys/61283953ab854a00080547b6 😎 Browse the preview: https://deploy-preview-37--awesome-bhaskara-b7d76c.netlify.app/ |
thescientist13
commented
Aug 20, 2021
| @@ -97,6 +81,19 @@ class SlideList extends LitElement { | |||
| document.dispatchEvent(new CustomEvent('slide-selected', { detail: slide })); | |||
| } | |||
|
|
|||
| slideLoaded(slide) { | |||
There was a problem hiding this comment.
The only slight downside with this approach is that it causes the scaling to "snap" into place which may be somewhat noticeable.
But, if we apply this style directly the template, then it will also be scaled down in the main window too... so 🤷♂️
thescientist13
changed the title
<iframe>s<iframe>s in the preview list so all content can be seen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #7
Summary of Changes
Before
https://awesome-bhaskara-b7d76c.netlify.app/
After
TODO
16:9?4:3? something else? - deferring to default theming and styles for baseline presentation slides #6