Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm shoelace hackathon #18

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

thescientist13
Copy link
Owner

@thescientist13 thescientist13 commented Oct 24, 2024

builds off of #14

Testing out a few things for fun

PNPM

Started out using pnpm and originally faced this issue since technically our demo uses the @lit-labs/ssr package "first party", which breaks pnpm's no-hosting approach

  

This was solved by setting shamefully-hoist in .npmrc

shamefully-hoist=true

This wasn't a problem, but then needed to patch something for Greenwood and ultimately had to rollback to using npm because:

  1. patch-package doesn't support pnpm - Support pnpm package manager ds300/patch-package#35
  2. pnpm's own patch feature doesn't seem to work - pnpm patch-commit always says "No changes were found to the following directory", even when there was a change pnpm/pnpm#8666

Shoelace

Works great*, but just needs some help from Greenwood to handle package exports it seems 🎉

Screenshot 2024-10-24 at 5 17 46 PM

* SSR support is not available though - shoelace-style/shoelace#1641

FontAwesome

Using fontawesome.css seems to be inhibited due to use of content which doesn't seem to get processed correctly by csstree

Screenshot 2024-10-24 at 5 19 52 PM

Greenwood

Looks like we need to better support an object for package.json exports map

Should all test this in Node 20 / 22

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
greenwood-lit-ssr-yp27 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 9:09pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant