forked from ProjectEvergreen/greenwood-demo-adapter-vercel
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pnpm shoelace hackathon #18
Draft
thescientist13
wants to merge
10
commits into
main
Choose a base branch
from
pnpm-shoelace-hackathon
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thescientist13
force-pushed
the
chore/upgrade-greenwood-v0.30.0
branch
from
October 25, 2024 18:04
b0b2346
to
ae72260
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds off of #14
Testing out a few things for fun
PNPM
Started out using pnpm and originally faced this issue since technically our demo uses the @lit-labs/ssr package "first party", which breaks pnpm's no-hosting approach
This was solved by setting
shamefully-hoist
in .npmrcThis wasn't a problem, but then needed to patch something for Greenwood and ultimately had to rollback to using npm because:
Shoelace
Works great*, but just needs some help from Greenwood to handle package exports it seems 🎉
FontAwesome
Using fontawesome.css seems to be inhibited due to use of
content
which doesn't seem to get processed correctly by csstreeGreenwood
Looks like we need to better support an object for package.json
exports
mapShould all test this in Node 20 / 22