Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import CSS in Card component #7

Merged
merged 8 commits into from
Nov 9, 2023
Merged

import CSS in Card component #7

merged 8 commits into from
Nov 9, 2023

Conversation

thescientist13
Copy link
Owner

@thescientist13 thescientist13 commented Sep 7, 2023

Summary

Wanted to test out / demonstrate being able to import CSS into a web component for inlining. Goal would be to have Greenwood align around the standard soon.

TODO

  1. File is missing on Vercel
  2. Need to patch greenwood/cli for some import.meta.url support - custom imports bundling breaks when used in API routes and SSR pages ProjectEvergreen/greenwood#1151
    • rollup.config.js needs support for greenwoodResourceLoader support for API routes (and SSR pages?)
    • Probably time to vend / own the handling of meta imports, or submit a PR? (Honestly, I think I'm ok with pulling everything in internally and dropping the dependency completely - might have to modify it to only act on a filter determined by Greenwood resource plugins though, e.g. asset vs chunk?)
  3. Support bare specifiers in custom loader resovling of URLs - custom loader hook not handling bare specifiers when resolve URLs (invalid URL) ProjectEvergreen/greenwood#1161
    • loader.js doesn't to handle node: specifiers? Or I think we were getting relative paths for specifiers?

@thescientist13 thescientist13 added enhancement New feature or request needs upstream labels Sep 7, 2023
@thescientist13 thescientist13 self-assigned this Sep 7, 2023
@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
greenwood-htmx ✅ Ready (Inspect) Visit Preview Nov 9, 2023 2:27am

@thescientist13 thescientist13 merged commit 82d76fc into master Nov 9, 2023
1 check passed
@thescientist13 thescientist13 deleted the import-css branch November 9, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant