add linter

theruziev · May 25, 2024 · 6f49523 · 6f49523
1 parent fafc5a6
commit 6f49523
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -23,3 +23,13 @@ jobs:
 
     - name: Test
       run: go test -v -race ./...
+
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Run GolangCI-Lint
+        uses: golangci/golangci-lint-action@v2
+        with:
+          version: v1.42.1
diff --git a/internal/pkg/healthcheck/healthcheck_test.go b/internal/pkg/healthcheck/healthcheck_test.go
@@ -9,7 +9,7 @@ import (
 )
 
 func TestNewLivenessHandler(t *testing.T) {
-	req, err := http.NewRequest("GET", "/live", nil)
+	req, err := http.NewRequest("GET", "/live", http.NoBody)
 	require.NoError(t, err)
 
 	rr := httptest.NewRecorder()
@@ -23,7 +23,7 @@ func TestNewLivenessHandler(t *testing.T) {
 func TestNewReadinessHandler(t *testing.T) {
 	t.Run("not serving", func(t *testing.T) {
 		healthcheck := NewHealthCheck()
-		req, err := http.NewRequest("GET", "/ready", nil)
+		req, err := http.NewRequest("GET", "/ready", http.NoBody)
 		require.NoError(t, err)
 
 		healthcheck.Shutdown()
@@ -36,7 +36,7 @@ func TestNewReadinessHandler(t *testing.T) {
 
 	t.Run("serving", func(t *testing.T) {
 		healthcheck := NewHealthCheck()
-		req, err := http.NewRequest("GET", "/ready", nil)
+		req, err := http.NewRequest("GET", "/ready", http.NoBody)
 		require.NoError(t, err)
 
 		healthcheck.Resume()

diff --git a/internal/pkg/info/info_test.go b/internal/pkg/info/info_test.go
@@ -10,7 +10,7 @@ import (
 )
 
 func TestHandler(t *testing.T) {
-	req, err := http.NewRequest("GET", "/info", nil)
+	req, err := http.NewRequest("GET", "/info", http.NoBody)
 	if err != nil {
 		t.Fatal(err)
 	}