Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added "phase transition properties" to pyrrhotite in mines16 data file #25

Merged
merged 2 commits into from
Mar 5, 2021

Conversation

cardinalgeo
Copy link
Contributor

I added the "phase transition properties" (m_phase_trans_props) to the pyrrhotite entry in the mines16 data file. It seems that the pyrrhotite entry is the only one requiring correction. In this case—and in many cases in other data files—temperature is the only property tabulated, so the info stored in m_phase_trans_props is redundant wrt what is already stored in the entry. However, both ThermoFun and Reaktoro throw errors (see screenshot for ThermoFun attached) when trying to calculate thermo. properties for pyrrhotite at temperatures above its phase transitions, so it seems this redundant info is still required. In the future, would it be possible to take the temperature from limitsTP when m_phase_trans_props is not specified? This would reduce redundant info in the data file in the case that only phase transition temperature would be included in m_phase_trans_props (i.e., dS, dH, dV, dT/dP of transition are unknown/zero).
Screen Shot 2021-02-25 at 10 03 17 PM

@cardinalgeo
Copy link
Contributor Author

Also, I made the above change in the thermofun repository rather than the thermohubclient repository, as I couldn't find the mines16 data file in the latter. Does thermohubclient use the mines16 datafile stored in the thermofun repository?

@gdmiron
Copy link
Member

gdmiron commented Mar 5, 2021

There is no connection between these files and the thermohub database. But your issues gave me an idea to keep a github repo as a connection where people can suggest fixes :). I also have ti add in the CI that when a commit to master is executed the database in thermohub should be updated.

In any case I have update the data in ThermoHub.

@gdmiron gdmiron merged commit ca89018 into thermohub:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants