added "phase transition properties" to pyrrhotite in mines16 data file #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the "phase transition properties" (
m_phase_trans_props
) to the pyrrhotite entry in the mines16 data file. It seems that the pyrrhotite entry is the only one requiring correction. In this case—and in many cases in other data files—temperature is the only property tabulated, so the info stored inm_phase_trans_props
is redundant wrt what is already stored in the entry. However, both ThermoFun and Reaktoro throw errors (see screenshot for ThermoFun attached) when trying to calculate thermo. properties for pyrrhotite at temperatures above its phase transitions, so it seems this redundant info is still required. In the future, would it be possible to take the temperature fromlimitsTP
whenm_phase_trans_props
is not specified? This would reduce redundant info in the data file in the case that only phase transition temperature would be included inm_phase_trans_props
(i.e., dS, dH, dV, dT/dP of transition are unknown/zero).