Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --isolate option in README #77

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Add --isolate option in README #77

merged 4 commits into from
Oct 22, 2024

Conversation

CanonicalJP
Copy link

@CanonicalJP CanonicalJP commented Oct 12, 2024 •
edited
Loading

Description

Added the --isolatedoption to tests so that the nonce limit assertion is properly executed for cases like Truster.t.sol or Puppet.t.sol

--isolated
Whether to enable isolation of calls. In isolation mode all top-level calls are executed as a separate transaction in a separate EVM context, enabling more precise gas accounting and transaction state changes

Changes

  • Updated README.md

Related to

  • See discussion #57

@CanonicalJP CanonicalJP mentioned this pull request Oct 12, 2024
Closed
@tinchoabbate
Copy link
Collaborator

Hey @CanonicalJP thanks for proposing this. I'll need to review this flag better and see whether it actually doesn't cause any other problems. I'll come back here once done and we can merge.

@tinchoabbate tinchoabbate self-requested a review October 22, 2024 13:42
@tinchoabbate tinchoabbate changed the base branch from master to v4-dev October 22, 2024 13:43
@tinchoabbate tinchoabbate changed the title Added --isolated to tests Add --isolate option in README Oct 22, 2024
tinchoabbate
tinchoabbate approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@tinchoabbate tinchoabbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified the text a bit. Thanks!

@tinchoabbate tinchoabbate merged commit 30e631a into theredguild:v4-dev Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinchoabbate tinchoabbate tinchoabbate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CanonicalJP @tinchoabbate