Skip to content

Commit

Permalink
Fix minor syntax error in type hash (#75)
Browse files Browse the repository at this point in the history
* fix: minor syntax error in Request's typeHash located at naive-receiver/BasicForwarder.sol

This commit fixes an issue in the _REQUEST_TYPEHASH definition within the BasicForwarder contract by adding a missing closing parenthesis in the typeHash string.
This error was non-compliant with the EIP-712 standard and could result in the rejection of legitimate requests.

---------

Co-authored-by: tincho <[email protected]>
  • Loading branch information
santi-nihany and tinchoabbate authored Oct 22, 2024
1 parent b3f1405 commit 1eca050
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/naive-receiver/BasicForwarder.sol
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ contract BasicForwarder is EIP712 {
error InvalidValue();

bytes32 private constant _REQUEST_TYPEHASH = keccak256(
"Request(address from,address target,uint256 value,uint256 gas,uint256 nonce,bytes data,uint256 deadline"
"Request(address from,address target,uint256 value,uint256 gas,uint256 nonce,bytes data,uint256 deadline)"
);

mapping(address => uint256) public nonces;
Expand Down

0 comments on commit 1eca050

Please sign in to comment.