Enhance CLR resolve in EF Core #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thepirat000
added a commit
that referenced
this pull request
Aug 8, 2020
…320) - Audit.EntityFramework: Adding boolean `EarlySavingAudit` setting to AuditDbContext to allow the audit event to be saved **before** the entity saving operation takes place. Related to #316. - Audit.NET.ElasticSearch: Upgrade NEST reference to version 7.8.2 to fix exception *Could not load type Elasticsearch.Net.IInternalSerializerWithFormatter from assembly Elasticsearch.Net* (#313)
|
This was added on version 16.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
In our project we have some derived / proxy classes to represent our entities (types that inherit from an entity defined on the
DbContextbut that themselves are not). EF handles these classes fine, but despite theAuditEventbeing created with all the entities it was not being persisted by Audit.NET.I tracked the cause to the code in
EntityFrameworkDataProvider.InsertEventwhere the call toGetEntityType()would returnnullfor these type of classes. I propose a small tweak to how theClrtype is resolved using this method instead. It should have the exact behavior as theFindEntityTypebeing called now, but will also check the base class if needed.