Bug fix for refund_application_fee #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 8, 2015 15:45
…rue" instead of boolean because Guzzle converts it to bad value
|
Just a quick bump, could we get this merged? dev-master as it currently stands does not process refunds correctly. Thanks! |
greydnls
added a commit
that referenced
this pull request
Apr 14, 2015
Bug fix for refund_application_fee
|
@andrewtweber thanks for fixing this and apologies for introducing the bug in the first place! |
|
@cfreear No problem. The void thing was not your fault, it was a pull request I had submitted after yours but was merged before yours :) And the "true" thing could happen to anybody |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fa2ad61 included the
refund_application_feeparameter. Had two minor issues with it.true, which Guzzle converts to integer1instead of string"true". Stripe expects a string value"true"or"false". See Boolean values guzzle/guzzle#588