-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shipping preference option to RestPurchaseRequest #184
base: master
Are you sure you want to change the base?
Conversation
Any chance of getting this merged anytime soon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it works.
You should probably...
- Make the "NO_SHIPPING" a class constant
- Add comments, especially for setShippingPreference() so it's clear what exactly it does and what the options are (if there are more)
d36db0a
to
eb29e8c
Compare
@SlimDeluxe Thanks for your advices. I add comments on supported values for |
@jlttt I tested the |
This will need a manual merge because of the conflicts. I'll get to that when I have sufficient time. |
a41dda5
to
456f758
Compare
@delatbabel I update the PR and remove the conflicts. |
@BrightSkyz just copy the file manually until they merge it. |
can someone merge this? we also need it |
I would propose to make you changes in : |
Is there any update on this? |
Any updates on this? Can we merge this? :) |
Why the hell is this not merged yet? |
Usually when I want something done I use words like "please" not "why the hell". However I'm not your mother. |
... but it got your attention after more than 5 years :) |
Fix #175.
Add
shipping_preference
option to RestPurchaseRequest which allow to disable the shipping address with value set toNO_SHIPPING
.