Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse request parameters #1407

Merged
merged 2 commits into from
May 10, 2024
Merged

Parse request parameters #1407

merged 2 commits into from
May 10, 2024

Conversation

eugene-borovov
Copy link
Contributor

@Sephster I have implemented my proposal.

  • Params parsed to non-empty string
  • Scalar params cast to string
  • Empty string treats as null
  • Non-scalar params throws invalidRequest
  • Remove string checks
  • Null checks have been shorten to null-coalesce operator

I will be glad if it helps.

@eugene-borovov eugene-borovov force-pushed the fix-passport-compatibility branch from 3a6a313 to df39bf6 Compare May 6, 2024 23:18
@Sephster Sephster merged commit 7596935 into thephpleague:fix-passport-compatibility May 10, 2024
13 of 15 checks passed
@Sephster
Copy link
Member

@eugene-borovov thank you very much for this PR. Saved me a great deal of time and looks good. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eugene-borovov @Sephster