Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PSR15/PSR-17 compliant middleware #1029

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

datapp
Copy link
Contributor

@datapp datapp commented Jul 8, 2019

resolves issue #942

@Sephster
Copy link
Member

Apologies for the delay on looking at this @datapp. I'm planning on merging this in later today although I will likely move the middleware into its own PSR folder instead of including PSR in the name. Many thanks for your efforts with this!

@carpabg
Copy link

carpabg commented Jan 6, 2020

This branch has not been merged yet. Could you merge it please @Sephster ?

@Sephster
Copy link
Member

Sephster commented Jan 6, 2020

Sorry I completely forgot about this. I'm focusing on the Device Auth Grant at the moment but will pick this up as soon as I can.

@delboy1978uk
Copy link

bump :-)

@interface-master
Copy link

bump, please - this looks good 👍

@jg-development
Copy link

any updates on this?

Copy link
Contributor

@eugene-borovov eugene-borovov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Authorization Server Middleware doesn`t work :-(

public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
{
try {
$response = $this->server->respondToAccessTokenRequest($request, $this->responseFactory->createResponse());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should return the response here

}

// Pass the request on to the next responder in the chain
return $handler->handle($request);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This statement is unreachable.

$requestHandlerMock
);

$this->assertEquals(200, $response->getStatusCode());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests for the body of the response. Now it is empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants