Support for ID token verification #119
Conversation
| use Google\Client; | ||
|
|
There was a problem hiding this comment.
That's because you likely don't have the dependency installed; it's used in the new method and if it doesn't exist and you call it, you get the runtime error.
There was a problem hiding this comment.
It is literally not used in this file.
| public function createResourceOwnerFromIdToken(string $idToken): GoogleUser { | ||
| if (!class_exists(Client::class)) { | ||
| throw new \RuntimeException('google/apiclient library required for ID token verification.'); | ||
| } | ||
| $client = new Client(['client_id' => $this->clientId]); | ||
| $user = new GoogleUser($client->verifyIdToken($idToken)); | ||
| $this->assertMatchingDomain($user->getHostedDomain()); | ||
| return $user; |
There was a problem hiding this comment.
Code style needs to be updated, and tests added.
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| namespace League\OAuth2\Client\Provider; | |||
|
|
|||
| use Firebase\JWT\JWK; | |||
| use Google\Client; | |||
There was a problem hiding this comment.
Client is used in this file.
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| namespace League\OAuth2\Client\Provider; | |||
|
|
|||
| use Firebase\JWT\JWK; | |||
There was a problem hiding this comment.
Also not required, and I don't think it is even installed.
|
Closing this, since the author has not addressed review comments in over a year. |
|
I would still like to loop around on this but understand the trend is to close stale issues. Hopefully we can re-open it when I come back around. |
Native apps can receive ID tokens directly from Google in that auth flow; this provides some basic support with an eye toward more OIDC integration in this library.