fix for invalid expires value #929
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #929 +/- ##
===========================================
Coverage 100.00% 100.00%
+ Complexity 190 181 -9
===========================================
Files 20 20
Lines 514 463 -51
===========================================
- Hits 514 463 -51
|
ramsey
reviewed
Dec 22, 2021
|
|
||
| $token = $this->getAccessToken($options); | ||
|
|
||
| $this->assertSame($token->getExpires(), $token->getTimeNow()); |
There was a problem hiding this comment.
I'm not sure what you're trying to test here, but 'TEXT' can't be the same as the return value of getTimeNow(), which is the current time stamp, so the tests are failing.
ramsey
reviewed
Dec 10, 2024
Comment on lines
+124
to
+125
| if (!is_numeric($expires)) { | ||
| $expires = intval($expires); |
There was a problem hiding this comment.
I'm not sure this check is useful. If something is not numeric, it usually won't have an intval worth using.
For example: https://3v4l.org/9r3Wj
|
Merged to the Thank you for contributing! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug for PHP 7.1+:
When attempting to add a non-numeric value
$expirestogetTimeNowan error is thrown. This should be non-breaking and preserve PHP 5 behavior.