Introduce ResponseParsingException and throw this exception in …

[tandhika]

…AbstractProvider::parseResponse() if necessary

[tandhika]

This PR aims at resolving issue #626

[tandhika]

The failed test was due to a bug in json_decode of php5.6, which accepts empty string as a valid json.

$ php -a
Interactive mode enabled

php > echo phpversion() . "\n"; json_decode('',true); echo json_last_error_msg();
5.6.40-24+ubuntu16.04.1+deb.sury.org+1
No error
php > 

$ php -a
Interactive mode enabled

php > echo phpversion() . "\n"; json_decode('',true); echo json_last_error_msg();
7.4.3
Syntax error
php > 

I'll fix the test and resubmit the PR

[codecov]

Codecov Report

Merging #825 (b7841a4) into master (77def43) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #825   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       180       184    +4     
===========================================
  Files             20        21    +1     
  Lines            464       476   +12     
===========================================
+ Hits             464       476   +12     

Impacted Files	Coverage Δ
src/Provider/AbstractProvider.php	100.00% <100.00%> (ø)
...rc/Provider/Exception/ResponseParsingException.php	100.00% <100.00%> (ø)

[tandhika]

I have fixed some broken changes after merging from current master.

[ramsey]

Maybe we always throw the exception, no matter what?

I know this suggestion is somewhat of a BC break, but if you have ResponseParsingException extend UnexpectedValueException, then anyone catching that exception will start catching the new exceptions and can decide what to do about them.

@shadowhand, @stevenmaguire, thoughts?

[tandhika]

I like your suggestion. I can implement the changes if no objection coming from @shadowhand and @stevenmaguire

[tandhika]

So, I have incorporated reviewer suggestions into the last commit, but I kept the BC until there is a need to change that as well. Thx @ramsey for the suggestions. If I should squash all my commits, please let me know.