Fix: Prefer inconclusive mimetype over null #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2023
|
@frankdejonge Could I bother you to please take a look at this PR? It's causing us some grief and we'd like to know if you will be accepting this pull request (or one like it), or if we will need to handle this scenario in our own application logic. |
|
Thank you! |
|
This PR seems to have broken the Laravel test suite: laravel/framework#49229 |
|
Sorry about that @driesvints, I've made an effective revert on this while making the PR functionality an opt-in. It's released as 3.23.0 |
|
@frankdejonge thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the scenario where
detectMimeTypeFromFile()detects an inconclusive mimetype, so we fallback todetectMimeTypeFromPath(), which returns null.Instead of returning null (which will result in
LocalFilesystemAdapterthrowing aUnableToRetrieveMetadataexception), we should return the inconclusive result. Valid but inconclusive is better than an exception.Related issue: