Implement readStream #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sandisk phpseclib didn't support this in the past, would you happen to know from which version on out they added this? |
|
@frankdejonge It's supported since 0.3.8 (Sep 13, 2014) |
|
I've removed the StreamedReading polyfill and tagged 1.0.5 which includes this patch. |
|
Cheers! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though
phpseclibdoes support writing directly to a resource,StreamedReadingTraitpolyfill was being used forreadStream, which meant that entire file contents would be read into memory before being written to a stream. This would result inAllowed memory size of x bytes exhaustederrors when attempting to download large files.Tested this with a 1.7GB file and memory usage did not exceed 10MB.