Add setter and getter for directoryPerm parameter #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danut007ro is there a reason why you'd want this to be exposed? A particular use-case? |
|
Yes. For instance I want the newly created folders to have a specific permission flag. 0755 in my case |
|
Any chance of merging this? helios-ag/FMElfinderBundle#133 has been merged so it's using some functionality not present yet. Thanks. |
|
@danut007ro yeah, looks good. Tests are missing though. Can you add those? |
|
I just added the tests, please review. Thanks. |
|
Any news on this, please? |
frankdejonge
added a commit
that referenced
this pull request
Apr 16, 2015
Add setter and getter for directoryPerm parameter
|
@danut007ro it's merged and 1.0.4 is tagged to include this. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add setter and getter for directoryPerm parameter. Related to helios-ag/FMElfinderBundle#133 and thephpleague/flysystem#457