Fix listContents() when includes a directory #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What does this Pull Request Do? ------------------------------- * Modified the `normalizeListingObject()` method. Identify the type of the object to normalize. If it's a 'file' the method will still return the same as before, if it's a 'dir' we take out `visibility` and `size` from the returned array. How should this be manually tested? ----------------------------------- A test was included with a similar output you can get in a server, which doesn't include the 'size'. Any background context you want to provide? ------------------------------------------- Currently there's a php `Notice` when trying to list the content of a directory with sub-directories. What are the relevant tickets? ------------------------------ * [Undefined index: size when trying to get the listing of a directories with subdirectories · Issue thephpleague#2 · thephpleague/flysystem-sftp](thephpleague#2) Any extra info? --------------- This is a minor bug. Please, give it a try and let me know.
|
@frankdejonge any feedback here? |
frankdejonge
added a commit
that referenced
this pull request
Feb 23, 2015
Fix listContents() when includes a directory
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request Do?
normalizeListingObject()method. Identify the type of the object to normalize. If it's a 'file' the method will still return the same as before, if it's a 'dir' we take outvisibilityandsizefrom the returned array.How should this be manually tested?
A test was included with a similar output you can get in a server, which doesn't include the 'size'.
The test is mostly the same as
testListContents. I can fix that test to reflect the situation where the server doesn't return the 'size' and remove the last test I created, if you think it's best.Any background context you want to provide?
Currently there's a php
Noticewhen trying to list the content of a directory with sub-directories.What are the relevant tickets?
Any extra info?
This is a minor bug. Please, give it a try and let me know.