Speedup build and reduced package size #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabiang looks good! I'll wait for Travis to finish. |
| @@ -1,4 +1,3 @@ | |||
| vendor | |||
| composer.lock | |||
There was a problem hiding this comment.
This should remain ignored.
There was a problem hiding this comment.
There was a problem hiding this comment.
That's absolutely right, for applications, not for libraries.
There was a problem hiding this comment.
At IPC Spring 2015 he said also for libraries, if you want.
There was a problem hiding this comment.
There are multiple views on this matter, mine and many others are "don't commit it for libs".
fabiang
changed the title
frankdejonge
added a commit
that referenced
this pull request
Dec 8, 2015
Speedup build and reduced package size
|
Tagged as 1.0.8 |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've made some small improvements:
phpunit.phpIf you add a secret environment variable named
GITHUB_OAUTH_TOKENto the Travis job you won't run into „api rate limit“ errors.