-
Notifications
You must be signed in to change notification settings - Fork 221
Commit
…S adapter
- Loading branch information
There are no files selected for viewing
4 comments
on commit ea10034
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frankdejonge are you aware this breaks the functionality in of ->exists()
? Currently a lot of users using Laravel and using this package can no longer user the exists()
function, since it returns an Exception, which then ends up in UnableToCheckFileExistence
... See laravel/framework#45639
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frankdejonge are you aware this breaks the functionality in of
->exists()
? Currently a lot of users using Laravel and using this package can no longer user theexists()
function, since it returns an Exception, which then ends up inUnableToCheckFileExistence
... See laravel/framework#45639
i reverted from 3.15.0 to 3.10 because of ->exists() errors. doesn't seem to be fixed yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frankdejonge are you aware this breaks the functionality in of
->exists()
? Currently a lot of users using Laravel and using this package can no longer user theexists()
function, since it returns an Exception, which then ends up inUnableToCheckFileExistence
... See laravel/framework#45639i reverted from 3.15.0 to 3.10 because of ->exists() errors. doesn't seem to be fixed yet.
Although less sufficient, but instead of decreasing the version, we use the get function with a try-catch as a workaround.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesObjectExistV2
accepts 4 arguments, butdoesObjectExist
only 3. It is not enough to just change the method name.DeleteMarker
should be in use as a third argument. Maybe it makes sense to have it asfalse
for the hotfix, as it was the behaviour before