Skip to content

Commit

Permalink
[apache#4370]feat(iceberg): support view interface for Iceberg REST s…
Browse files Browse the repository at this point in the history
…erver
  • Loading branch information
theoryxu committed Sep 26, 2024
1 parent c6f451f commit d5481b0
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@ boolean catalogTypeNotMemory() {
return !catalogType.equals(IcebergCatalogBackend.MEMORY);
}

boolean catalogTypeNotHive() {
return !catalogType.equals(IcebergCatalogBackend.HIVE);
}


abstract void initEnv();

abstract Map<String, String> getCatalogConfig();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -560,6 +560,7 @@ void testRegisterTable() {
}

@Test
@EnabledIf("catalogTypeNotHive")
void testCreateViewAndDisplayView() {
String originTableName = "iceberg_rest_table_test.create_table_for_view_1";
String viewName = "iceberg_rest_table_test.test_create_view";
Expand All @@ -581,6 +582,7 @@ void testCreateViewAndDisplayView() {
}

@Test
@EnabledIf("catalogTypeNotHive")
void testViewProperties() {
String originTableName = "iceberg_rest_table_test.create_table_for_view_2";
String viewName = "iceberg_rest_table_test.test_create_view_with_properties";
Expand Down Expand Up @@ -620,6 +622,7 @@ void testViewProperties() {
}

@Test
@EnabledIf("catalogTypeNotHive")
void testDropView() {
String originTableName = "iceberg_rest_table_test.create_table_for_view_3";
String viewName = "iceberg_rest_table_test.test_drop_view";
Expand All @@ -637,6 +640,7 @@ void testDropView() {
}

@Test
@EnabledIf("catalogTypeNotHive")
void testReplaceView() {
String originTableName = "iceberg_rest_table_test.create_table_for_view_4";
String viewName = "iceberg_rest_table_test.test_replace_view";
Expand All @@ -658,6 +662,7 @@ void testReplaceView() {
}

@Test
@EnabledIf("catalogTypeNotHive")
void testShowAvailableViews() {
String originTableName = "iceberg_rest_table_test.create_table_for_view_5";
String viewName1 = "iceberg_rest_table_test.show_available_views_1";
Expand All @@ -675,6 +680,7 @@ void testShowAvailableViews() {
}

@Test
@EnabledIf("catalogTypeNotHive")
void testShowCreateStatementView() {
String originTableName = "iceberg_rest_table_test.create_table_for_view_6";
String viewName = "iceberg_rest_table_test.show_create_statement_view";
Expand Down

0 comments on commit d5481b0

Please sign in to comment.