-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable passing in custom py_runtime #98
Enable passing in custom py_runtime #98
Conversation
ecee048
to
fd886bb
Compare
It seems like there should be a way to pass a constraint to the toolchain resolution, I’m just unsure how to do it. |
I'm not sure how to do it either, though our use of rules_uv requires multiple pip_compile rules with a different version of python for each of them. This seems to work well in our use case since we'd need to specify a different runtime for the non-default python toolchain. I'm also not sure how to add tests for this. |
Thanks -- this seems like something we can/should be able to get help for on Bazel slack, I'll start a thread. |
Added an example of usage in the PR description to help with the conversation/thread. |
fd886bb
to
9caae52
Compare
9caae52
to
8ac045c
Compare
seems like this will be super nice for projects that support multiple py versions where the default is not the lowest supported version |
Could use some help and opinions on the attribute name.
This does add rules_python as a bazel dep in order to use the
PyRuntimeInfo
provider. Not sure if that's undesirable. It seems to make sense since rules_uv already depends on the toolchain made available by it.Example usage:
Fixes #97