Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Only trigger email_user_submission_confirmation event once per session #3967

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Only trigger email_user_submission_confirmation event once per session #3967

wants to merge 1 commit into from

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Nov 15, 2024 •
edited
Loading

What's the problem?

  • When an application is submitted to multiple locations, the email_user_submission_confirmation event trigger is called multiple times, resulting in multiple emails being sent to applicants from PlanX.
  • This is recreatable locally, and can be observed as a pattern via GovNotify or the Hasura event log - we can see grouped events and emails for the same PlanX session

What's the solution?

  • Adds a check within the query, so that the trigger is only called once

@github-actions GitHub Actions
Copy link

Pizza

Deployed 63023e8 to https://3967.planx.pizza.

Useful links:

@DafyddLlyr DafyddLlyr requested a review from a team November 15, 2024 16:15
@DafyddLlyr DafyddLlyr marked this pull request as ready for review November 15, 2024 16:15
@DafyddLlyr
Copy link
Contributor Author

Fix multiple confirmation mails being sent for a single submission

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DafyddLlyr