docs: How to add a send destination #3962
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
changed the title
| - Submission handling (parse session, authenticate with send destination, construct payload for submission) | ||
| - Audit record creation (write to `new_destination_applications` table) | ||
| - Add `service.ts` layer for business logic | ||
| - Update `docs.yaml` Swagger file |
There was a problem hiding this comment.
Appreciate you outlining these steps - would personally order them differently though:
- Setup / planx-core
- Editor
- API
- Secret management
----- (above this line is usually enough to have a "proof of concept" to test on staging! often important to understand where this line is for fast external partner turn-around imo) -----
- Database (Hasura)
- Metabase
- Data sanitation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something I've been keeping track of whilst adding the GOSS integration, finally typed up my rough notes.
There's a lot of stuff here! Certainly a lot of room for improvement and simplification I think in this process, and it's what's inspired the questions raised in #3961
Ideally, we'd end up distilling this down to -
team_integrationstable though?)I think the rest can largely be made generic and standard between send destinations.
As I keep working on GOSS using the existing setup, I'll dip in and out of the doc to update it or add more details. Thoughts very welcome on the outline that's currently here though.