feat: calculate totalInterest in Mortgage class
#119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
so fairholdLandPurchase and fairholdLandRent now take marketPurchase
|
If we merge #123 into this branch first, it should resolve the test issue above! |
DafyddLlyr
requested changes
Oct 17, 2024
app/models/Mortgage.ts
Outdated
| @@ -110,4 +112,9 @@ export class Mortgage { | |||
|
|
|||
| return yearlyPaymentBreakdown; | |||
| } | |||
| private calculateTotalInterest() { | |||
| const totalInterest = parseFloat((this.principal * this.interestRate * this.termYears).toFixed(2)) | |||
| console.log("Total interest: ", totalInterest) | |||
There was a problem hiding this comment.
nit: Leftover console.log
There was a problem hiding this comment.
Good catch, thanks!
…tests fix: update tests following interest calculation functionality
DafyddLlyr
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mortgageclass)NB: There's another instance of
principalthat will also need fixing once #117 is merged.Closes #118