Skip to content

Commit

Permalink
revert: tidy up types on FairholdLandRent #27 (#37)
Browse files Browse the repository at this point in the history
* typo fix

Co-authored-by: Dafydd Llŷr Pearson <[email protected]>

* fix: Rebase issues

---------

Co-authored-by: Gabriele Granello <[email protected]>
  • Loading branch information
DafyddLlyr and gabrielegranello authored Aug 2, 2024
1 parent 519b5c4 commit 98a9d6a
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions app/models/tenure/FairholdLandRent.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { MONTHS_PER_YEAR } from "../constants";
import { Fairhold } from "../Fairhold";
import { Mortgage } from "../Mortgage";
import { MONTHS_PER_YEAR } from "../constants";

interface FairholdLandRentParams {
averageRentYearly: number;
Expand All @@ -27,7 +26,7 @@ type Lifetime = {
}[];

export class FairholdLandRent {
/** Mortgage on the depreaciated value of the house */
/** Mortgage on the depreciated value of the house */
depreciatedHouseMortgage: Mortgage;
/** discounted value of the monthly land rent according to fairhold */
discountedLandRentMonthly: number;
Expand Down Expand Up @@ -60,7 +59,7 @@ export class FairholdLandRent {
landPriceOrRent: averageRentLandMonthly,
});
const discountedLandRentMonthly =
fairholdLandRent.calculateDiscountedPriceOrRent();
fairholdLandRent.discountedLandPriceOrRent

return discountedLandRentMonthly;
}
Expand Down Expand Up @@ -144,8 +143,8 @@ export class FairholdLandRent {
maintenanceCost: maintenanceCostIterative,
fairholdRentLand: fairholdRentLandIterative,
houseMortgagePaymentYearly: houseMortgagePaymentYearlyIterative,
}); // add the current price to the new build price forecast
});
}
return lifetime; // save the object
return lifetime;
}
}

0 comments on commit 98a9d6a

Please sign in to comment.