[GenAIOrchestrator] Add QA chain #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgandiverrez
approved these changes
Jul 10, 2024
...strator-server/src/main/python/server/src/gen_ai_orchestrator/services/langchain/qa_chain.py
Outdated
Show resolved
Hide resolved
.../orchestrator-server/src/main/python/server/src/gen_ai_orchestrator/models/rag/rag_models.py
Outdated
Show resolved
Hide resolved
morgandiverrez
approved these changes
Aug 5, 2024
Benvii
requested changes
Aug 8, 2024
There was a problem hiding this comment.
Thanks for this great PR, small remarks / changes can be made. On of them is related to API contract to make it more clear that the QA chain uses only a user query as input.
See my comments.
Out of scope This PR will have impact for #1675 as it will be merge before, when rebasing #1675 we will need to update QA Query to add the vector db settings and so the vector store factory instanciation.
.../orchestrator-server/src/main/python/server/src/gen_ai_orchestrator/models/rag/rag_models.py
Show resolved
Hide resolved
...hestrator-server/src/main/python/server/src/gen_ai_orchestrator/routers/requests/requests.py
Outdated
Show resolved
Hide resolved
.../orchestrator-server/src/main/python/server/src/gen_ai_orchestrator/models/rag/rag_models.py
Outdated
Show resolved
Hide resolved
...strator-server/src/main/python/server/src/gen_ai_orchestrator/services/langchain/qa_chain.py
Outdated
Show resolved
Hide resolved
...strator-server/src/main/python/server/src/gen_ai_orchestrator/services/langchain/qa_chain.py
Show resolved
Hide resolved
gen-ai/orchestrator-server/src/main/python/server/tests/services/test_qa_chain.py
Outdated
Show resolved
Hide resolved
gen-ai/orchestrator-server/src/main/python/server/tests/services/test_qa_chain.py
Outdated
Show resolved
Hide resolved
Benvii
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a QA chain, service and router.
Resolves #1640