-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GenAIOrchestrator] Add QA chain #1641
[GenAIOrchestrator] Add QA chain #1641
Conversation
...strator-server/src/main/python/server/src/gen_ai_orchestrator/services/langchain/qa_chain.py
Outdated
Show resolved
Hide resolved
.../orchestrator-server/src/main/python/server/src/gen_ai_orchestrator/models/rag/rag_models.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me, but i haven't tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this great PR, small remarks / changes can be made. On of them is related to API contract to make it more clear that the QA chain uses only a user query as input.
See my comments.
Out of scope This PR will have impact for #1675 as it will be merge before, when rebasing #1675 we will need to update QA Query to add the vector db settings and so the vector store factory instanciation.
.../orchestrator-server/src/main/python/server/src/gen_ai_orchestrator/models/rag/rag_models.py
Show resolved
Hide resolved
...hestrator-server/src/main/python/server/src/gen_ai_orchestrator/routers/requests/requests.py
Outdated
Show resolved
Hide resolved
.../orchestrator-server/src/main/python/server/src/gen_ai_orchestrator/models/rag/rag_models.py
Outdated
Show resolved
Hide resolved
...strator-server/src/main/python/server/src/gen_ai_orchestrator/services/langchain/qa_chain.py
Outdated
Show resolved
Hide resolved
...strator-server/src/main/python/server/src/gen_ai_orchestrator/services/langchain/qa_chain.py
Show resolved
Hide resolved
gen-ai/orchestrator-server/src/main/python/server/tests/services/test_qa_chain.py
Outdated
Show resolved
Hide resolved
gen-ai/orchestrator-server/src/main/python/server/tests/services/test_qa_chain.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the updates, good PR I'm merging it right now.
Add a QA chain, service and router.
Resolves #1640