Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHPUnit deprecations #150

Merged
merged 4 commits into from
Oct 3, 2020
Merged

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Oct 2, 2020

Replaces #145, it adds @jmsche suggestion and requires explicitly doctrine/persistance.

I also added conflict with zendframework/zend-code < 3.3.1 because of zendframework/zend-code#158 and with doctrine/orm < 2.6.3 because of doctrine/orm#7325.

@theofidry
Copy link
Owner

7x: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?

I'm not sure from where this is coming from but looks easy to fix hopefully?

@jmsche
Copy link
Contributor

jmsche commented Oct 2, 2020

The only place in the package's code where I found continue is there: https://github.com/theofidry/AliceDataFixtures/blob/master/src/Bridge/Symfony/DependencyInjection/Compiler/DeprecateServicesPass.php

Couldn't find any place using switch, so my guess is, it's located in vendors :/

@franmomu
Copy link
Contributor Author

franmomu commented Oct 2, 2020

Let me try if it's doctrine/orm, if it's not, I'll take a look later today.

@franmomu
Copy link
Contributor Author

franmomu commented Oct 2, 2020

I added conflict with zendframework/zend-code < 3.3.1 because of zendframework/zend-code#158 and with doctrine/orm < 2.6.3 because of doctrine/orm#7325.

@jmsche
Copy link
Contributor

jmsche commented Oct 2, 2020

Congrats @franmomu :)

@theofidry theofidry merged commit 7165a10 into theofidry:master Oct 3, 2020
@theofidry
Copy link
Owner

Thank you very much @franmomu

@franmomu franmomu deleted the fix_deprecations branch October 4, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants