Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ellipsis on help cards #90

Merged
merged 2 commits into from
Feb 29, 2024
Merged

add ellipsis on help cards #90

merged 2 commits into from
Feb 29, 2024

Conversation

fsoussand
Copy link
Collaborator

@fsoussand fsoussand commented Nov 16, 2023

What is this pull request doing ?

On rajoute un ellispsis sur les cartes d'info
#87

Screenshot

image image

How is it done ?

How to test ?

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for a11yinyerface ready!

Name Link
🔨 Latest commit 61e3dee
🔍 Latest deploy log https://app.netlify.com/sites/a11yinyerface/deploys/65e08d462bf7780007c691c6
😎 Deploy Preview https://deploy-preview-90--a11yinyerface.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RobinCar
Copy link
Collaborator

RobinCar commented Feb 29, 2024

Tu penserais quoi au lieu d'avoir un bouton au milieu on mettait plutôt un "Voir plus" et "Voir moins" sur la droite, j'ai l'impression que c'est un design plus courant

Et avec un text plus petit peut être

@fsoussand fsoussand force-pushed the add-ellipsis-on-help-cards branch from d9a3197 to 61e3dee Compare February 29, 2024 13:57
@fsoussand fsoussand merged commit f4cbe24 into main Feb 29, 2024
5 checks passed
@fsoussand fsoussand deleted the add-ellipsis-on-help-cards branch February 29, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants