-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tnbcfundme.co.za- milestone01- 01 #386
Comments
When signing up, password field isn't blank. |
Agree with @tspearing - we should never ask for a signing key from a user |
Asking for a signing key isn't an actual issues as long as it's never stored in a database But i can see this is just asking for it. There should be useful for them: |
@tspearing and @wakawakathedev I had to ask for the signing key because the payment handler on the js library require's the signing key from the person who is sending the funds so that it can tell if it's really them... But I don't store it on the database... That's why it isn't required when u registering for an account like the account number (The account is stored on the database), it's only required when u sending funds. |
First thought, know we have the account. VerifySignature method, this might
be something to leverage?
…On Mon, 20 Dec 2021 at 3:42 AM, lwazi4787 ***@***.***> wrote:
@tspearing <https://github.com/tspearing> and @wakawakathedev
<https://github.com/wakawakathedev> I had to ask for the signing key
because the payment handler on the js library require's the signing key
from the person who is sending the funds so that it can tell if it's really
them... But I don't store it on the database... That's why it isn't
required when u registering for an account like the account number (The
account is stored on the database), it's only required when u sending funds.
—
Reply to this email directly, view it on GitHub
<#386 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVMEOEGVTWMWOKQZHILPQK3URYYQXANCNFSM5KFJPFPQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
is the -js repo passing transactions via the server or in client? |
We still aren't comfortable with asking users for their signing key. There will be a case where someone doesn't understand that they can have multiple accounts within a wallet and they share their signing key with all of their TNBC. Possible solutions:
|
If we want to verify an account is owned by a user, we could also
ask/create a “create signature”.
…On Thu, 23 Dec 2021 at 11:58 AM, tspearing ***@***.***> wrote:
We still aren't comfortable with asking users for their signing key. There
will be a case where someone doesn't understand that they can have multiple
accounts within a wallet and they share their signing key with all of their
TNBC. Possible solutions:
1. Integrate with a 3rd party wallet such as KeySign or the official
wallet.
2. Create an account for each user and cause when they sign up and
then users can send TNBC from a wallet to their tnbcfuneme account which is
used to send to causes.
—
Reply to this email directly, view it on GitHub
<#386 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVMEOEGWAMUOG7FCUXQ2K6LUSKM7DANCNFSM5KFJPFPQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This is in those documents i provided above |
@tspearing can you send me a link to the third party wallets and what do you mean by cause/causes... |
@mrbusysky can help with 3rd party wallet integration. By 'cause' I meant a project to donate to. So, it would be a separate stand alone wallet. |
@mrbusysky can you please send me a link to third party wallet integration. |
Link to the milestone and objectives table.
#314
Detailed log of all completed objectives including valid proof of work.
Please use fake email for now, when I complete the documentation for the website, email verification will be activated.
https://www.tnbcfundme.co.za/
Project Wallet
158fa206324ca39e0b5b3156f96f243d2233545ef9b4b2dea1fae8aee258c9cf
The text was updated successfully, but these errors were encountered: