Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tnbcfundme.co.za- milestone01- 01 #386

Closed
lwazi4787 opened this issue Dec 16, 2021 · 12 comments
Closed

tnbcfundme.co.za- milestone01- 01 #386

lwazi4787 opened this issue Dec 16, 2021 · 12 comments
Labels
Milestone Payout Request Payout Request Request Edit Some fields are missing or need to be updated.

Comments

@lwazi4787
Copy link

Link to the milestone and objectives table.

#314

Detailed log of all completed objectives including valid proof of work.

Please use fake email for now, when I complete the documentation for the website, email verification will be activated.

https://www.tnbcfundme.co.za/

Project Wallet

158fa206324ca39e0b5b3156f96f243d2233545ef9b4b2dea1fae8aee258c9cf

@lwazi4787 lwazi4787 added the Milestone Payout Request Payout Request label Dec 16, 2021
@lwazi4787 lwazi4787 changed the title NAME_OF_PROJECT - NAME_OF_MILESTONE - MILESTONE_NUMBER tnbcfundme.co.za- milestone01- 01 Dec 16, 2021
@tspearing
Copy link

When signing up, password field isn't blank.
Unable to send TNBC to someone. Page hangs.
However, we don't see why a signing key is necessary. People should sign up and provide their account number. Then when funds are sent, people can use an official app. This way, the signing key is never transmitted within tnbcfuneme.

@wakawakathedev
Copy link

Agree with @tspearing - we should never ask for a signing key from a user

@mrbusysky
Copy link
Contributor

mrbusysky commented Dec 19, 2021

When signing up, password field isn't blank. Unable to send TNBC to someone. Page hangs. However, we don't see why a signing key is necessary. People should sign up and provide their account number. Then when funds are sent, people can use an official app. This way, the signing key is never transmitted within tnbcfuneme.

Asking for a signing key isn't an actual issues as long as it's never stored in a database

But i can see this is just asking for it.

There should be useful for them:
https://docs.google.com/document/d/1zWl2W5zUWbG45-eD21kaiMIYZaEOPa6rWUKsxJ-UJr8/edit
https://docs.google.com/document/d/1VRGC1siRPaAfDD3bM_pGncs-czmD4xHj9XiN6RbEgbc/edit

@lwazi4787
Copy link
Author

@tspearing and @wakawakathedev I had to ask for the signing key because the payment handler on the js library require's the signing key from the person who is sending the funds so that it can tell if it's really them... But I don't store it on the database... That's why it isn't required when u registering for an account like the account number (The account is stored on the database), it's only required when u sending funds.

@wakawakathedev
Copy link

wakawakathedev commented Dec 20, 2021 via email

@mrbusysky
Copy link
Contributor

is the -js repo passing transactions via the server or in client?
Because it can't be passed through your servers.

@tspearing
Copy link

We still aren't comfortable with asking users for their signing key. There will be a case where someone doesn't understand that they can have multiple accounts within a wallet and they share their signing key with all of their TNBC. Possible solutions:

  1. Integrate with a 3rd party wallet such as KeySign or the official wallet.
  2. Create an account for each user and cause when they sign up and then users can send TNBC from a wallet to their tnbcfuneme account which is used to send to causes.

@manishram manishram added the Request Edit Some fields are missing or need to be updated. label Dec 23, 2021
@wakawakathedev
Copy link

wakawakathedev commented Dec 23, 2021 via email

@mrbusysky
Copy link
Contributor

If we want to verify an account is owned by a user, we could also ask/create a “create signature”.

On Thu, 23 Dec 2021 at 11:58 AM, tspearing @.> wrote: We still aren't comfortable with asking users for their signing key. There will be a case where someone doesn't understand that they can have multiple accounts within a wallet and they share their signing key with all of their TNBC. Possible solutions: 1. Integrate with a 3rd party wallet such as KeySign or the official wallet. 2. Create an account for each user and cause when they sign up and then users can send TNBC from a wallet to their tnbcfuneme account which is used to send to causes. — Reply to this email directly, view it on GitHub <#386 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVMEOEGWAMUOG7FCUXQ2K6LUSKM7DANCNFSM5KFJPFPQ . You are receiving this because you were mentioned.Message ID: @.>

This is in those documents i provided above

@lwazi4787
Copy link
Author

@tspearing can you send me a link to the third party wallets and what do you mean by cause/causes...

@tspearing
Copy link

@mrbusysky can help with 3rd party wallet integration.

By 'cause' I meant a project to donate to. So, it would be a separate stand alone wallet.

@lwazi4787
Copy link
Author

@mrbusysky can you please send me a link to third party wallet integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Milestone Payout Request Payout Request Request Edit Some fields are missing or need to be updated.
Projects
None yet
Development

No branches or pull requests

5 participants