Add google cloud datastore implementation #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADD google cloud datastore index definition [mandatory for test]
|
Can index.yaml be moved somewhere else? i.e. test directory? |
|
yes, it can |
|
yes |
|
already move the file to test folder |
|
Can you also extend the readme? |
|
btw: Can you please use the use function |
update README to cover "cloud datastore"
|
done |
|
Is the datastore “testable” via travis or should we skip it in the tests? |
|
I think so, but I haven't got lucky with cloud datastore emulator in the past few days |
|
@amura2406 any updates to this? I'd also like to use cloud datastore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I just added google cloud datastore implementation for my own usage, just thought that you might want to merge it in your main repository.
Feedbacks are welcome.