-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add positioning options to FwbModal #293
Conversation
✅ Deploy Preview for sensational-seahorse-8635f8 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Although maybe I should have used Flowbite's implementation to be in line with the core lib:
But I think we should keep logical prop value names ( @Sqrcz If my assumptions are correct please let me know and I'll do the rest. |
Thanks for the fix. Any updates on a publish timeline? This would be a nice feature for a project right now. :) Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it and it works as it should. 🎉
I like this naming better for the reasons you've mentioned... 💯
Solid work, thank you!
Currently
FwbModal
doesn't have position prop to control modal's placement on the screen. This PR adds this feature taking into consideration possible usage in RTL (Right-to-Left) mode.display: block
and theposition
prop sets corresponding classes responsible for modal's alignment. Default position iscenter
.ms-auto
instead ofml-auto
.Closes: #279 #235