fix: CodePreview - show explicit false props
#985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ince it defaults to `true`
rluders
approved these changes
Sep 22, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #985 +/- ##
==========================================
- Coverage 99.54% 93.52% -6.03%
==========================================
Files 163 182 +19
Lines 6621 7890 +1269
Branches 401 439 +38
==========================================
+ Hits 6591 7379 +788
- Misses 30 511 +481
☔ View full report in Codecov by Sentry. |
SutuSebastian
deleted the
bufix/code-preview/show-explicit-false-props
branch
maman
pushed a commit
to transkripid/flowbite-react
that referenced
this pull request
Oct 7, 2023
fix: code preview - show explicit false props; removing `sortProps` since it defaults to `true` Co-authored-by: Sebastian Sutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the setting
useBooleanShorthandSyntaxis not set tofalsein the https://github.com/algolia/react-element-to-jsx-string/tree/master options object, it will remove for good any prop looking like thisprop={false}, even tho the default is set totruewithin the component.This is a problem because it can misguide people when they look at the code snippet, if they copy it and paste it -> they should see the same results, which today is not the case, for example for https://www.flowbite-react.com/docs/components/datepicker#autohide.
Changes
visible={false})sortPropssince it defaults totrueThis issue currently affects the following components:
MDX source code
Before
After