Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timeline-horizontal #510

Merged
merged 3 commits into from
Jan 8, 2023

Conversation

DoIttikorn
Copy link
Contributor

Description

remove margin-top while timeline horizontal and change align-items center to base-line

before:
image

after
image

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Breaking changes

Please document the breaking changes if suitable.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit Test

Test Configuration:

  • N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Base: 97.46% // Head: 98.96% // Increases project coverage by +1.50% 🎉

Coverage data is based on head (7fc5114) compared to base (3387128).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
+ Coverage   97.46%   98.96%   +1.50%     
==========================================
  Files         127      127              
  Lines        5518     5528      +10     
  Branches      443      464      +21     
==========================================
+ Hits         5378     5471      +93     
+ Misses        140       57      -83     
Impacted Files Coverage Δ
src/lib/components/Timeline/Timeline.tsx 100.00% <100.00%> (+20.23%) ⬆️
src/lib/components/Timeline/TimelinePoint.tsx 100.00% <100.00%> (+58.82%) ⬆️
src/lib/theme/default.ts 100.00% <100.00%> (ø)
src/lib/components/Timeline/TimelineContext.tsx 82.35% <0.00%> (+29.41%) ⬆️
src/lib/components/Timeline/TimelineTime.tsx 100.00% <0.00%> (+33.33%) ⬆️
src/lib/components/Timeline/TimelineTitle.tsx 100.00% <0.00%> (+36.36%) ⬆️
src/lib/components/Timeline/TimelineBody.tsx 100.00% <0.00%> (+36.84%) ⬆️
src/lib/components/Timeline/TimelineContent.tsx 100.00% <0.00%> (+38.09%) ⬆️
src/lib/components/Timeline/TimelineItem.tsx 100.00% <0.00%> (+48.00%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rluders
Copy link
Collaborator

rluders commented Jan 2, 2023

@DoIttikorn thank you. Just check the codecov/patch message and fix it, please. It seems that the introduced feature isn't covered by any unit test.

@rluders rluders requested review from rluders and yurisldk January 2, 2023 20:20
@rluders rluders linked an issue Jan 2, 2023 that may be closed by this pull request
@DoIttikorn
Copy link
Contributor Author

ok, I'm so sorry. I follow unit test again

@DoIttikorn
Copy link
Contributor Author

I write unit test Timeline success and trigger coverage report bot @rluders and review coding

@DoIttikorn
Copy link
Contributor Author

ready for review @rluders

@rluders rluders merged commit 89d2ff8 into themesberg:main Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

timeline horizontal fix css
2 participants