Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): fix the argTypes.weekStart.mapping on Datepicker.stories.tsx #1254

Merged

Conversation

ktanoooo
Copy link
Contributor

When you click Datepicker on the storybook, throws an invalid time value error.
I guess it is because the default value of weekStart arg becomes string Sunday by the argTypes.weekStart.mapping. The weekStart arg is expected the number.
This PR fixed the value of argTypes.weekStart.mapping to be only the string key.

- argTypes.weekStart.mapping: { 0: "Sunday", 1: "Monday", 2: "Tuesday", 3: "Wednesday", 4: "Thursday", 5: "Friday", 6: "Saturday", Sunday: 0, Monday: 1, Tuesday: 2, Wednesday: 3, Thursday: 4, Friday: 5, Saturday: 6 }
+ argTypes.weekStart.mapping: { Sunday: 0, Monday: 1, Tuesday: 2, Wednesday: 3, Thursday: 4, Friday: 5, Saturday: 6 }

fix #1167

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 5:51pm

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7461173) 99.54% compared to head (7bf4f8a) 97.38%.
Report is 192 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1254      +/-   ##
==========================================
- Coverage   99.54%   97.38%   -2.17%     
==========================================
  Files         163      216      +53     
  Lines        6621     9217    +2596     
  Branches      401      538     +137     
==========================================
+ Hits         6591     8976    +2385     
- Misses         30      241     +211     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@SutuSebastian SutuSebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datepicker on click throws invalid time value error in Default story
2 participants