Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(floatinglabel component): fix imports and code examples #1242

Merged
merged 1 commit into from
Jan 23, 2024
Merged

docs(floatinglabel component): fix imports and code examples #1242

merged 1 commit into from
Jan 23, 2024

Conversation

rizky201008
Copy link
Contributor

@rizky201008 rizky201008 commented Jan 22, 2024

I just changed the import error in all the floatingLabel code examples and changed the color in the floatingLabel.validation.tsx file because the success color and error color were confused with each other.

…lor at code example

I just changed the import error in all the floatingLabel code examples and changed the color in the
floatingLabel.validation.tsx file because the success color and error color were confused with each
other.
Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 6:20pm

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7461173) 99.54% compared to head (9648d70) 97.36%.
Report is 188 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1242      +/-   ##
==========================================
- Coverage   99.54%   97.36%   -2.18%     
==========================================
  Files         163      214      +51     
  Lines        6621     9083    +2462     
  Branches      401      530     +129     
==========================================
+ Hits         6591     8844    +2253     
- Misses         30      239     +209     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@SutuSebastian SutuSebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@SutuSebastian SutuSebastian merged commit afc4c64 into themesberg:main Jan 23, 2024
5 checks passed
@SutuSebastian SutuSebastian changed the title docs(floatinglabel component): i change import error and fix wrong co… docs(floatinglabel component): fix imports and code examples Jan 23, 2024
@SutuSebastian SutuSebastian added the 📚 documentation Improvements or additions to documentation label Jan 23, 2024
@rizky201008
Copy link
Contributor Author

Nice thanks 👍

abdulbasithqb pushed a commit to abdulbasithqb/flowbite-react that referenced this pull request Jan 31, 2024
themesberg#1242)

docs(floatinglabel component): i change import error and fix wrong color at code example

I just changed the import error in all the floatingLabel code examples and changed the color in the
floatingLabel.validation.tsx file because the success color and error color were confused with each
other.
abdulbasithqb pushed a commit to abdulbasithqb/flowbite-react that referenced this pull request Jan 31, 2024
themesberg#1242)

docs(floatinglabel component): i change import error and fix wrong color at code example

I just changed the import error in all the floatingLabel code examples and changed the color in the
floatingLabel.validation.tsx file because the success color and error color were confused with each
other.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants