Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination buttons still have hover styles when disabled #849

Closed
nigellima opened this issue Jul 12, 2023 · 1 comment · Fixed by #856
Closed

Pagination buttons still have hover styles when disabled #849

nigellima opened this issue Jul 12, 2023 · 1 comment · Fixed by #856
Assignees
Labels
🐛 bug Something isn't working confirmed This bug was confirmed good first issue Good for newcomers

Comments

@nigellima
Copy link
Collaborator

Describe the bug
When hovering the navigation buttons in the Pagination component, they still have hover styles being applied

pagination-disabled

To Reproduce
Steps to reproduce the behavior:

  1. Go to Documentation website
  2. Hover the disabled navigation buttons
  3. Scroll down to '....'
  4. See error

Expected behavior
Disabled buttons should not have any effect

Project information:

  • Flowbite React: v0.4.11
@rluders rluders added 🐛 bug Something isn't working confirmed This bug was confirmed good first issue Good for newcomers labels Jul 12, 2023
@kharbandaashu
Copy link
Contributor

@rluders / @nigellima I would like to work on this issue. please assign to me.

kharbandaashu pushed a commit to kharbandaashu/flowbite-react that referenced this issue Jul 13, 2023
…se theme

hover class was getting applied even when button is disabled. so, added enabled: attribute to each
hover class of pagination base theme. Now it will only show hover if button is enabled.

fix themesberg#849
rluders pushed a commit to kharbandaashu/flowbite-react that referenced this issue Jul 18, 2023
…se theme

hover class was getting applied even when button is disabled. so, added enabled: attribute to each
hover class of pagination base theme. Now it will only show hover if button is enabled.

fix themesberg#849
rluders pushed a commit that referenced this issue Jul 18, 2023
#856)

fix(pagination theme file): added enabled attribute for pagination base theme

hover class was getting applied even when button is disabled. so, added enabled: attribute to each
hover class of pagination base theme. Now it will only show hover if button is enabled.

fix #849

Co-authored-by: ashu.kharbanda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working confirmed This bug was confirmed good first issue Good for newcomers
Projects
None yet
3 participants