Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove user preference from Flowbite component #565

Closed
rluders opened this issue Jan 26, 2023 · 1 comment · Fixed by #582
Closed

Remove user preference from Flowbite component #565

rluders opened this issue Jan 26, 2023 · 1 comment · Fixed by #582
Labels
good first issue Good for newcomers 🚀 enhancement New feature or request
Milestone
0.4.0

Comments

@rluders
Copy link
Collaborator

rluders commented Jan 26, 2023

Is your feature request related to a problem? Please describe.
The #546 triggered a lot of discussion about data privacy and also it is the responsibility of the Flowbite component to handle user preference. And honestly, I think that it doesn't belong to the component since it can be restricted by a particular set or rules and laws that we are not aware of.

Describe the solution you'd like
Remove the user preference support from Flowbite component.

Describe alternatives you've considered
None

Additional context
None
@rluders rluders added the 🚀 enhancement New feature or request label Jan 26, 2023
@rluders rluders added this to the 0.4.0 milestone Jan 26, 2023
@rluders rluders added the good first issue Good for newcomers label Feb 1, 2023
@rluders rluders mentioned this issue Feb 5, 2023
Closed
haron68 added a commit to haron68/flowbite-react that referenced this issue Feb 6, 2023
@haron68
fix(theme): removed usePreferences
7fbfe4f 
Fixes bug with dark = false not working. Removed usePreferences because of potential legal issues
due to GDPR

BREAKING CHANGE: ThemeProps no longer includes usePreferences

fix themesberg#565, fix themesberg#581
@haron68 haron68 mentioned this issue Feb 6, 2023
Merged
9 tasks
@tulup-conner
Copy link
Collaborator

Follow this via #582

haron68 added a commit to haron68/flowbite-react that referenced this issue Feb 21, 2023
@haron68
refactor(theme): improve readability
6ddcccb 
improve readability and fix merge conflicts. Update documentation for ThemePage

themesberg#565
rluders pushed a commit that referenced this issue Feb 21, 2023
@haron68
feat(/lib/components/flowbite): remove usePreferences (#582)
77cbc27 
* fix(flowbite themeprops): fix bug with user preferences overriding dark = false

Found an issue where userpreferences when set to true overrides dark = false in theme props which is
a confusing developer experience

fix #581

* fix(theme): removed usePreferences

Fixes bug with dark = false not working. Removed usePreferences because of potential legal issues
due to GDPR

BREAKING CHANGE: ThemeProps no longer includes usePreferences

fix #565, fix #581

* refactor(theme): refactor useThemeMode

Refactored useThemeMode to fetch context state

* refactor(theme): improve readability

improve readability and fix merge conflicts. Update documentation for ThemePage

#565

* refactor(theme): remove === check for false to set light mode

Since we're no longer using localStorage no need to hard check for false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers 🚀 enhancement New feature or request
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

feat(/lib/components/flowbite): remove usePreferences haron68/flowbite-react
2 participants
@rluders @tulup-conner