Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copyright to clipboard when user copy #1325

Closed
wants to merge 1 commit into from

Conversation

Angboo
Copy link

@Angboo Angboo commented Dec 22, 2019

PR Checklist

  • The commit message follows guidelines for NexT.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

Does this PR introduce a breaking change?

  • Yes.
  • No.

@welcome
Copy link

welcome bot commented Dec 22, 2019

Thanks so much for opening your first PR here!

@claassistantio
Copy link

claassistantio commented Dec 22, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@stevenjoezhang stevenjoezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributing!

However, this feature is not always user-friendly. Please make it a NexT plugin and submit a Pull Request here: https://github.com/next-theme/awesome-next#next-plugins

@Angboo
Copy link
Author

Angboo commented Dec 26, 2019

@stevenjoezhang �I think this should be turned on when "creative_commons" is in use, so it should not be a plugins

@stevenjoezhang
Copy link
Contributor

Thank you for your suggestions, but this does affect the reading experience. In fact, the use of creative commons is good enough now, it's a moral issue, not a technical one. As a Hexo theme, we must consider both bloggers and readers. Maybe there will be a better solution in the future.

@Angboo
Copy link
Author

Angboo commented Dec 30, 2019

@stevenjoezhang Sorry, I ignore that, And I will create a plugin for next-theme

@stevenjoezhang
Copy link
Contributor

stevenjoezhang commented Dec 30, 2019

Looking forward to your pull request 🎉

https://github.com/next-theme/awesome-next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants