Ads 5776 update stable to stable next #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dctr" param (prebid#9169) * removed logic to append jw data to dctr param * removed unneeded code * removed extra html page for testing
* Prebidmanager analytics adapter: reduce requests size * Update prebidmanagerAnalyticsAdapter.js * Update prebidmanagerAnalyticsAdapter.js --------- Co-authored-by: Patrick McCann <[email protected]>
* Resetdigital Bid Adapter: Add custom fields to bid request and GDRP support * fixing comments * fix bidfloor settings * get kewords from request and site meta tag" * fix bild errors --------- Co-authored-by: nicolas taglienti <[email protected]>
* add support for native * wrap native tests around FEATURES.NATIVE * remove commented out code * HB-16092 support multiformat parameter * do not generate imp if has only banner media type * check banner bid type only if mediaTypes.banner * new multiformat logic * bidonmultiformat * fixes: do not set empty keywords; better behavior for floors. * currency is always added * remove prorperties that are already set by ortb --------- Co-authored-by: Michele Nasti <[email protected]>
* Alkimi bid adapter * Alkimi bid adapter * Alkimi bid adapter * alkimi adapter * onBidWon change * sign utils * auction ID as bid request ID * unit test fixes * change maintainer info * Updated the ad unit params * features support added * transfer adUnitCode * transfer adUnitCode: test * AlkimiBidAdapter getFloor() using * ALK-504 Multi size ad slot support * ALK-504 Multi size ad slot support --------- Co-authored-by: Alexander <[email protected]> Co-authored-by: Alexander Bogdanov <[email protected]> Co-authored-by: Alexander Bogdanov <[email protected]> Co-authored-by: motors <[email protected]> Co-authored-by: Kalidas Engaiahraj <[email protected]> Co-authored-by: mik <[email protected]>
* Parse and emit seatnonbid from server * Fix testing adjustments * Use onResponse for seatNonBids * Fix linting error * Emit to auction and add unit tests * Use optional property chaining * returnallbidstatus * fix varname in spec
* Fix: creating host correctly when http or https are added from the beginning * Fix :: Changed double quotes for single quotes * Fix :: Getting the full page URL * Fix :: Changed order params * Fix :: Replaced quotes from double to simple * Fix :: Adapting format to lint * Remove TODO comment * Added more controls * camelcase fix * Changed test * Remove "inIframe" util * Fix: solved error getOs and created getVendor functions * Fix: Solved CircelCI format problems --------- Co-authored-by: Jordi Arnau <[email protected]> Co-authored-by: ruben_tappx <[email protected]>
* Novatiq snowflake userId submodule Novatiq snowflake userId submodule initial release * change request updates added novatiq info /modules/userId/userId.md added novatiq info /modules/userId/eids.md added novatiq eids /modules/userId/eids.js added novatiq module in /modules/.submodules.json removed unnecessary value from getId response * Update novatiqIdSystem_spec.js removed unnecessary srcid value * Update novatiqIdSystem.md Novatiq ID System: updated novatiq snowflake ID description * use the sharedId if available and configured * updated docs * test changes * defensive code not required * Use the prebid storage manager instead of using native functions * doc changes * trailing spaces * Allow configuration of the sync URL and to allow callbacks for specific custom partner integrations * update documentation * attempt to fix firefox test timeout * include the AIB Vendor Id * fix async response --------- Co-authored-by: novatiq <[email protected]>
…rebid#9587) * id-6129: don't write to local storage without consent * id-6129: clean up * id-6129: clean up * id-6129: refactor * id-6129: use deepAccess * id-6129: unit tests * id-6129: logging * id-6129: improve log
* GDPR (consentManagement): fix `actionTimeout` behavior * Add test case for actionTimeout = 0
* add VisibleMeasures adapter * fix test
… and metadata (prebid#9579) * only send hb_acat if acat is present * removed a couple unneeded files * reverted a few more unneeded changes * Changes to support dchain object. And passing metadata in logger log including dchain * Added missing code * Added the missing metadata in PubaticBidAdapter * Revrting the changes from jlquaccia/UOE-8728 * Test cases added for metadata and dchain --------- Co-authored-by: jlquaccia <[email protected]>
…sent on Page (prebid#9530) * only send hb_acat if acat is present * removed a couple unneeded files * reverted a few more unneeded changes * updated acat test
…d#9606) * cut url whit url length is greater than 255 * Fix lint
* Added implementation of the Relevad Real-Time Data Provider * removed bidder from the testing HTML file * Addressed reviewer's request w.r.t. removing bidder-specific handling' * set page url * Addressed code review comments: fixed email address, added description of ORTB attributes we pass to the bidders * Addressed code review comments --------- Co-authored-by: Relevad <>
* AMX bid adapter: add gpp support, cookie sync improvements * fix unit tests
* add support for native * wrap native tests around FEATURES.NATIVE * remove commented out code * HB-16092 support multiformat parameter * do not generate imp if has only banner media type * check banner bid type only if mediaTypes.banner * new multiformat logic * bidonmultiformat * fixes: do not set empty keywords; better behavior for floors. * currency is always added * remove prorperties that are already set by ortb * fix tests --------- Co-authored-by: Michele Nasti <[email protected]>
…bid#9611) * allows publisher to override video params * passes proper config to ima
* rbc-OPATH-367: support bidfloor bidding parameter * rbc-OPATH-367-added-tests --------- Co-authored-by: robert.charlton <[email protected]> Co-authored-by: robert-charlton-ttd <[email protected]>
* Realvu analytics adapter: fix test failures on Edge * Remove realVu tests
* tag '7.44.0': (320 commits) Prebid 7.44.0 release Concert Bid Adapter: Enable support for additional userId's (prebid#9780) vidazoo Bid Adapter: update support of metaData (prebid#9749) Criteo Bid Adapter: Read GPP from ortb2 object (prebid#9775) OpenxOrtbAdapter: add back missing params support for coppa and video (prebid#9782) size map support (prebid#9772) Multiple bids in one request to Adrino Adserver (prebid#9742) Multiple modules: decouple GVL IDs from storage access control (prebid#9736) Update gumgumBidAdapter.js (prebid#9779) appnexus bid adapter - add gvlids to aliases (prebid#9777) Update undertoneBidAdapter.js (prebid#9778) PubMatic Bid Adapter: native 1.2 support (prebid#9701) Criteo ID Module: Add error callback for pixel sync call (prebid#9754) TTD Bid Adapter: add support for video.plcmt and imp.rwdd (prebid#9762) BrightcomSSP, Brightcom: remove options overide from buildRequests (prebid#9753) AIDEM Bid Adapter: extended app/site parameters on win notice (prebid#9765) ZetaGlobalSsp Bid Adapter: provide tagid from params (prebid#9764) Craft Bid Adapter : update for imuIdSystem (prebid#9757) LocalStorage availability logging (prebid#9755) Greenbids Analytics Adapter: create new analytics adapter for Greenbids (prebid#9690) ...
* Admatic Bidder Adaptor * Update admaticBidAdapter.md * Update admaticBidAdapter.md * remove floor parameter * Update admaticBidAdapter.js * Admatic Bid Adapter: alias and bid floor features activated * Admatic adapter: host param control changed * Alias name changed. * Revert "Admatic adapter: host param control changed" This reverts commit de7ac85. * added alias feature and host param * Revert "added alias feature and host param" This reverts commit 6ec8f45. * Revert "Alias name changed." This reverts commit 661c54f. * Revert "Admatic Bid Adapter: alias and bid floor features activated" This reverts commit 7a2e0e2. * Revert "Update admaticBidAdapter.js" This reverts commit 7a845b7. * Revert "remove floor parameter" This reverts commit 7a23b05. * Admatic adapter: host param control && Add new Bidder * Revert "Admatic adapter: host param control && Add new Bidder" This reverts commit 3c797b1. * commit new features * Update admaticBidAdapter.js * updated for coverage * sync updated * Update adloader.js * AdMatic Bidder: development of user sync url * Update admaticBidAdapter.js * Set currency for AdserverCurrency: bug fix * Update admaticBidAdapter.js * update * admatic adapter video params update * Update admaticBidAdapter.js * update * Update admaticBidAdapter.js * update * update * Update admaticBidAdapter_spec.js * Update admaticBidAdapter.js * Update admaticBidAdapter.js * Revert "Update admaticBidAdapter.js" This reverts commit 1216892. * Revert "Update admaticBidAdapter.js" This reverts commit b1929ec. * Revert "Update admaticBidAdapter_spec.js" This reverts commit 1ca6597. * Revert "update" This reverts commit 689ce9d. * Revert "update" This reverts commit f381a45. * Revert "Update admaticBidAdapter.js" This reverts commit 38fd7ab. * Revert "update" This reverts commit a5316e7. * Revert "Update admaticBidAdapter.js" This reverts commit 60a28ca. * Revert "admatic adapter video params update" This reverts commit 31e69e8. * update
* TL-35335: Cast playbackmethod as array * TL-36204: Copy tid to imp extension obj * Added support for entire ortb2Imp obj * Only setting what exists in ortb2Imp.ext * Added additional test to check copy of entire ext obj * Revert "TL-36204: Copy tid to imp extension object" * TL-36204: Copying ortb2Imp.ext to impression ext obj * Added edge case logic and additional test * recos for tid change * Added spread operator to replace deepClone --------- Co-authored-by: nllerandi3lift <[email protected]> Co-authored-by: Nick Llerandi <[email protected]>
* Multiple modules: do not use bidderTimeout as TTL * Fix lint
* Update gridBidAdapter.js * Update gridBidAdapter_spec.js
…rebid#9882) This reverts commit 2edd264.
…ids present (prebid#9875) Co-authored-by: Alejandro Villanueva <[email protected]>
* feat: update Sovrn bid adapter to send gpp * style: eslint --------- Co-authored-by: feat: add video request fields <>
… gdprApplies to usersyncs (prebid#9885) * TL-35335: Cast playbackmethod as array * TL-36204: Copy tid to imp extension obj * Added support for entire ortb2Imp obj * Only setting what exists in ortb2Imp.ext * Added additional test to check copy of entire ext obj * Revert "TL-36204: Copy tid to imp extension object" * TL-36204: Copying ortb2Imp.ext to impression ext obj * Added edge case logic and additional test * recos for tid change * Added spread operator to replace deepClone * addresses gdprApplies --------- Co-authored-by: Patrick Loughrey <[email protected]>
Co-authored-by: dumitrubarbos <[email protected]>
Co-authored-by: Thomas De Stefano <[email protected]>
* Relevant Digital Bid Adapter * More tests + comments * Use the recommended onBidWon callback + live-placements in .md file * Remove unused imports + adjust example-parameters in .md file * Renamed files + rewritten test-cases * Added documentation for 'pbsBufferMs' setting * Added 'useSourceBidderCode' setting to use S2S bidder's code instead of the client-side code in responses
Bumps [engine.io](https://github.com/socketio/engine.io) and [socket.io](https://github.com/socketio/socket.io). These dependencies needed to be updated together. Updates `engine.io` from 6.2.1 to 6.4.2 - [Release notes](https://github.com/socketio/engine.io/releases) - [Changelog](https://github.com/socketio/engine.io/blob/main/CHANGELOG.md) - [Commits](socketio/engine.io@6.2.1...6.4.2) Updates `socket.io` from 4.5.3 to 4.6.1 - [Release notes](https://github.com/socketio/socket.io/releases) - [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md) - [Commits](socketio/socket.io@4.5.3...4.6.1) --- updated-dependencies: - dependency-name: engine.io dependency-type: indirect - dependency-name: socket.io dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* FreeWheel add floor price * FreeWheel code update * FreeWheel-SSP-Adapter: Update to use Vast 4.2 by default * FreeWheel-SSP-Adapter add userIdAsEids support * Freewheel-SSP-Adapter add test for eids * Freewheel SSP Adapter: add prebid version in request * code cleanup * FreeWheel SSP Bid Adapter: support video context and placement * update test * FreeWheel SSP Bid Adapter: add GPP support * Freewheel SSP Bid Adapter: test update
jakethekoenig
requested review from
bradchoate,
HojunByun,
a team and
santii7395
and removed request for
a team
hankyates-maven
approved these changes
May 24, 2023
bradchoate
approved these changes
May 24, 2023
There was a problem hiding this comment.
LGTM, although following this merge, it appears that we will have a delta with stable-next around these files which appear to have been updated in stable, but the changes were not propagated to stable-next:
- modules/mavenDistributionAnalyticsAdapter.js
- test/spec/modules/mavenDistributionAnalyticsAdapter_adUnits.json
- test/spec/modules/mavenDistributionAnalyticsAdapter_spec.js
- test/spec/modules/mavenDistributionAnalyticsAdapter_zoneMap.json
I'd recommend copying these into stable-next following this merge. And that means we will want to do a new build of our Prebid bundles for Phoenix (copying the prebid-next.min.js file to prebid.min.js will cause those adapter changes to be lost).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phoenix prebid update pr: https://github.com/themaven-net/tempest-phoenix/pull/4084