ADS-4131 update reporting format

[yonran]

More follow-up to ADS-4131

Discard events if LiftIgniter’s $p fails to load, rather than queuing forever. Instead of polling for $p every second, listen for the DOMContentLoaded event, since if $p is loaded, it should be defined in an embedded script. This will allow us to roll out to all of tempest-phoenix since LiftIgniter is not always loaded (particularly on children’s websites). And it prevents the memory leak when LiftIgniter fails to load due to a network error too. If $p does not load, then old bids are discarded once there are more than 32 bids.

Modify the batch format further per @partha0solapurkar and @vipulnaik’s specifications: report bids in cpmms as rounded price per million impressions rather than cpms price per thousand, and also include a price field that totals all the bids within the past second.

Make MavenDistributionAnalyticsAdapter logInfo its actions for debugging. Include the timestamp with logInfo, logWarn, and logError when ?pbjs_debug=true per @vipulnaik’s request

[vipulnaik]

LGTM, thanks so much @yonran!

[snark]

Has this been through a linter? Beyond that, you might want to keep this within the mavenDistribution module code, just to make it more feasible to merge it into the public Prebid.js repo.

[yonran]

Yes npx gulp test runs eslint. Vipul says he prefers to see the timestamp on all log messages including the ones internal to prebid. Yes it does make it annoying that it will make it harder to merge in the future.

[snark]

One minor comment that won't block merge, but you might want to address if we want to release this publicly.

Additionally, I'm not sure what value the summed CPMMs provides; it seems like this is going to inflate the perceived value of slots that attract a large number of bids, but I don't perceive there being a great deal of added value in a slot that attracts 10 $.50 CPM bids versus one that attracts 5. (Is this just to provide a rough measure of demand?) This certainly will work technically for that, though.

[yonran]

Additionally, I'm not sure what value the summed CPMMs provides; it seems like this is going to inflate the perceived value of slots that attract a large number of bids, but I don't perceive there being a great deal of added value in a slot that attracts 10 $.50 CPM bids versus one that attracts 5. (Is this just to provide a rough measure of demand?) This certainly will work technically for that, though.

For each slot within one auction, I take the max bid for that slot, not the sum of the bids for a the slot, so it should not inflate revenue that way. However, if the slot participates in multiple auctions before the ad is shown, then you’re right that I will double count the cpmms. Do we set it up so that the same slot participates in multiple auctions?