Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads 3946 ix timeout #15

Closed
wants to merge 2 commits into from
Closed

Ads 3946 ix timeout #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e203efe
ADS-3945 Add deal id as param to hummingbird
martiantim Mar 26, 2020
f572ccd
ADS-3946 Increase IX TTL
martiantim Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README_Maven.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,9 @@ You'll find the built prebid.js file in build/dist/prebid.js.

You'll find the built prebid.js file in build/dist/prebid.js.

## Building the Tempest Prebid Bundle

$ gulp build --modules=../phoenix/htdocs/js/prebid/modules-next.json #for prebid-next
$ gulp build --modules=../phoenix/htdocs/js/prebid/modules.json

You'll find the built prebid.js file in build/dist/prebid.js.
2 changes: 1 addition & 1 deletion modules/ixBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const SUPPORTED_AD_TYPES = [BANNER, VIDEO];
const BANNER_ENDPOINT_VERSION = 7.2;
const VIDEO_ENDPOINT_VERSION = 8.1;
const CENT_TO_DOLLAR_FACTOR = 100;
const BANNER_TIME_TO_LIVE = 35;
const BANNER_TIME_TO_LIVE = 300;
const VIDEO_TIME_TO_LIVE = 3600; // 1hr
const NET_REVENUE = true;
const PRICE_TO_DOLLAR_FACTOR = {
Expand Down
3 changes: 2 additions & 1 deletion modules/mavenAnalyticsAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,8 @@ let mavenAnalytics = Object.assign(adapter({hummingbirdUrl, analyticsType}), {
bidder: bid.bidderCode,
cpm: bid.cpm,
timeToRespond: bid.timeToRespond,
deal: !!bid.dealId
deal: !!bid.dealId,
dealId: bid.dealId
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the same field be used for whether there's a deal and for the ID? Like have "dealId" field mean ID if deal is there, otherwise undefined if no deal. Of course in this case "deal" may be used in many cases. No big deal, just something I noticed :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, done

});
});
// Zone info for all zones in play.
Expand Down