Skip to content

Commit

Permalink
Adman Adapter: add transactionID (prebid#10078)
Browse files Browse the repository at this point in the history
* Add Adman bid adapter

* Add supportedMediaTypes property

* Update ADman Media bidder adapter

* Remove console.log

* Fix typo

* revert package-json.lock

* Delete package-lock.json

* back to original package-lock.json

* catch pbjs error

* catch pbjs error

* catch pbjs error

* log

* remove eu url

* remove eu url

* remove eu url

* remove eu url

* remove eu url

* Update admanBidAdapter.js

add consnet to sync url

* Update admanBidAdapter.js

fix import

* Update admanBidAdapter.js

lint fix

* Update admanBidAdapter.js

lint fix

* Update admanBidAdapter.js

check consent object data availability

* сompatible with prebid v5

* add Lotame Panorama ID

* update getUserSyncs

* fix

* fix tests

* remove package-lock.json

* update sync url

* update test

* add idx (UserID Module)

* update tests

* remove traffic param

* handle transactionID param

* send transactionID param in imp.ext

* rename transactionID to transactionId

* update tests

---------

Co-authored-by: minoru katogi <[email protected]>
Co-authored-by: minoru katogi <[email protected]>
Co-authored-by: ADman Media <[email protected]>
Co-authored-by: SmartyAdman <[email protected]>
Co-authored-by: SmartyAdman <>
  • Loading branch information
5 people authored and Santiago Carabone committed Aug 22, 2023
1 parent 83f9469 commit d9860f7
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 2 deletions.
5 changes: 5 additions & 0 deletions modules/admanBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,11 @@ export const spec = {
bidFloor: getBidFloor(bid)
}

if (bid.transactionId) {
placement.ext = placement.ext || {};
placement.ext.tid = bid.transactionId;
}

if (bid.schain) {
placement.schain = bid.schain;
}
Expand Down
10 changes: 8 additions & 2 deletions test/spec/modules/admanBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,11 @@ describe('AdmanAdapter', function () {
let placements = data['placements'];
for (let i = 0; i < placements.length; i++) {
let placement = placements[i];
expect(placement).to.have.all.keys('placementId', 'eids', 'bidId', 'traffic', 'sizes', 'schain', 'bidFloor');
expect(placement).to.have.all.keys('placementId', 'eids', 'bidId', 'traffic', 'sizes', 'schain', 'bidFloor', 'ext');
expect(placement.schain).to.be.an('object')
expect(placement.ext).to.be.an('object')
expect(placement.ext).to.have.key('tid')
expect(placement.ext.tid).to.equal(bidBanner.transactionId);
expect(placement.placementId).to.be.a('number');
expect(placement.bidId).to.be.a('string');
expect(placement.traffic).to.be.a('string');
Expand All @@ -132,7 +135,10 @@ describe('AdmanAdapter', function () {
let placement = placements[i];
expect(placement).to.have.all.keys('placementId', 'eids', 'bidId', 'traffic', 'schain', 'bidFloor',
'playerSize', 'minduration', 'maxduration', 'mimes', 'protocols', 'startdelay', 'placement', 'skip',
'skipafter', 'minbitrate', 'maxbitrate', 'delivery', 'playbackmethod', 'api', 'linearity');
'skipafter', 'minbitrate', 'maxbitrate', 'delivery', 'playbackmethod', 'api', 'linearity', 'ext');
expect(placement.ext).to.be.an('object')
expect(placement.ext).to.have.key('tid')
expect(placement.ext.tid).to.equal(bidBanner.transactionId);
expect(placement.schain).to.be.an('object')
expect(placement.placementId).to.be.a('number');
expect(placement.bidId).to.be.a('string');
Expand Down

0 comments on commit d9860f7

Please sign in to comment.