Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch product listing (photos) basic flow #16

Merged
merged 42 commits into from
Nov 11, 2024

Conversation

marcusvx
Copy link

@marcusvx marcusvx commented Nov 5, 2024

  • Upgrades React to v18.x
  • Add craco configuration, allowing customization of webpack config
  • Add Ant Design to the project
  • Add Uppy and Transloadit
  • Implement basic flow for batch product listing (photos)
  • Fix some failing unit tests

@marcusvx marcusvx requested a review from rafaerod89 November 5, 2024 22:58
const middlewares = [
thunk.withExtraArgument(sdk),
analytics.createMiddleware(analyticsHandlers),
uppyReduxStore.middleware(),
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uppy is connected with the main Redux store, so we have only one source of truth, as it's suggested by Redux guidelines.

@marcusvx marcusvx self-assigned this Nov 5, 2024
@marcusvx marcusvx added the enhancement New feature or request label Nov 5, 2024
package.json Outdated Show resolved Hide resolved
@@ -0,0 +1,33 @@
import './marketplaceDefaults.css';

export const createTheme = branding => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!!

import BatchEditListingWizard from './BatchEditListingWizard/BatchEditListingWizard';

export const BatchEditListingPageComponent = props => {
const { currentUser, history, intl, params, page, onInitializeUppy, onSaveBatchListing } = props;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the 'tab' field we pass from the router?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's being used in src/containers/BatchEditListingPage/BatchEditListingWizard/BatchEditListingWizard.js.

BTW, I've updated the route to:
/listing/:category/:type/:tab

@@ -33,6 +33,25 @@
"AuthenticationPage.verifyEmailTitle": "{name}, bitte überprüfe deinen E-Mail-Posteingang, um deine E-Mail-Adresse zu bestätigen",
"Avatar.bannedUserDisplayName": "Gesperrter Benutzer",
"Avatar.deletedUserDisplayName": "Gelöschter Benutzer",
"BatchEditListingUploaderPanel.title": "Fotos hochladen",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of this is needed. But did you add this on the Sharetrive console?

If not let's touch base on how to do it because it is tricky

@@ -33,6 +33,25 @@
"AuthenticationPage.verifyEmailTitle": "{name}, check your email inbox to verify your email address",
"Avatar.bannedUserDisplayName": "Banned user",
"Avatar.deletedUserDisplayName": "Deleted user",
"BatchEditListingUploaderPanel.title": "Upload photos",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@@ -33,6 +33,25 @@
"AuthenticationPage.verifyEmailTitle": "{name}, revisa tu cuenta de correo para poder verificar tu cuenta.",
"Avatar.bannedUserDisplayName": "Usuario bloqueado",
"Avatar.deletedUserDisplayName": "Usuario eliminado",
"BatchEditListingUploaderPanel.title": "Subir fotos",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

src/util/api.js Outdated Show resolved Hide resolved
@rafaerod89 rafaerod89 merged commit 4e3ea6d into dev Nov 11, 2024
@rafaerod89 rafaerod89 deleted the feature/uppy-upload-products branch November 11, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants