-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch product listing (photos) basic flow #16
Conversation
marcusvx
commented
Nov 5, 2024
•
edited
Loading
edited
- Upgrades React to v18.x
- Add craco configuration, allowing customization of webpack config
- Add Ant Design to the project
- Add Uppy and Transloadit
- Implement basic flow for batch product listing (photos)
- Fix some failing unit tests
const middlewares = [ | ||
thunk.withExtraArgument(sdk), | ||
analytics.createMiddleware(analyticsHandlers), | ||
uppyReduxStore.middleware(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uppy is connected with the main Redux store, so we have only one source of truth, as it's suggested by Redux guidelines.
@@ -0,0 +1,33 @@ | |||
import './marketplaceDefaults.css'; | |||
|
|||
export const createTheme = branding => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!!
import BatchEditListingWizard from './BatchEditListingWizard/BatchEditListingWizard'; | ||
|
||
export const BatchEditListingPageComponent = props => { | ||
const { currentUser, history, intl, params, page, onInitializeUppy, onSaveBatchListing } = props; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the 'tab' field we pass from the router?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's being used in src/containers/BatchEditListingPage/BatchEditListingWizard/BatchEditListingWizard.js.
BTW, I've updated the route to:
/listing/:category/:type/:tab
src/containers/EditListingPage/EditListingWizard/EditListingWizard.js
Outdated
Show resolved
Hide resolved
src/containers/ManageListingsPage/ManageListingCard/ManageListingCard.js
Outdated
Show resolved
Hide resolved
@@ -33,6 +33,25 @@ | |||
"AuthenticationPage.verifyEmailTitle": "{name}, bitte überprüfe deinen E-Mail-Posteingang, um deine E-Mail-Adresse zu bestätigen", | |||
"Avatar.bannedUserDisplayName": "Gesperrter Benutzer", | |||
"Avatar.deletedUserDisplayName": "Gelöschter Benutzer", | |||
"BatchEditListingUploaderPanel.title": "Fotos hochladen", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of this is needed. But did you add this on the Sharetrive console?
If not let's touch base on how to do it because it is tricky
@@ -33,6 +33,25 @@ | |||
"AuthenticationPage.verifyEmailTitle": "{name}, check your email inbox to verify your email address", | |||
"Avatar.bannedUserDisplayName": "Banned user", | |||
"Avatar.deletedUserDisplayName": "Deleted user", | |||
"BatchEditListingUploaderPanel.title": "Upload photos", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
@@ -33,6 +33,25 @@ | |||
"AuthenticationPage.verifyEmailTitle": "{name}, revisa tu cuenta de correo para poder verificar tu cuenta.", | |||
"Avatar.bannedUserDisplayName": "Usuario bloqueado", | |||
"Avatar.deletedUserDisplayName": "Usuario eliminado", | |||
"BatchEditListingUploaderPanel.title": "Subir fotos", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here