fix(cli): Don’t use backticks to unbreak zsh compdef #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the generated zsh compdef contains something along the
lines of
I.e., it performs command substitution on ‘make’, which in the best
case fails with something along the lines of “make: *** No targets
specified and no makefile found. Stop.” and in the worst case ends up
running ‘make’ for you.
This issue should probably be brought up to clap-rs/clap so that it is
made to use single quotes instead of double quotes and escape
everything correctly.
For now, this commit fixes the issue by using “smart quotes” instead
of backticks.