Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shipa-2871] Adds volume name validators #258

Merged
merged 3 commits into from
Jun 7, 2022
Merged

[Shipa-2871] Adds volume name validators #258

merged 3 commits into from
Jun 7, 2022

Conversation

kavinaravind
Copy link
Contributor

@kavinaravind kavinaravind commented Jun 2, 2022

Description

This PR focuses on extra validation checks for volumes

  1. A compliant k8 volume name (conforms to the following regex: "[a-z0-9]([-a-z0-9]*[a-z0-9])?")
  2. Explicitly checking that the pvc exists via a k8 call and erroring if it does not

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (documentation addition or typo, file relocation)

Testing

  • New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
  • This change requires no testing (i.e. documentation update)

Documentation

  • All added public packages, funcs, and types have been documented with doc comments
  • I have commented my code, particularly in hard-to-understand areas

Final Checklist:

  • I followed standard GitHub flow guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Additional Information (omit if empty)

Please include anything else relevant to this PR that may be useful to know.

@kavinaravind kavinaravind merged commit 4d7b379 into main Jun 7, 2022
@kavinaravind kavinaravind deleted the shipa-2871 branch June 7, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants