-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for inline comments #11
base: main
Are you sure you want to change the base?
Conversation
I don't see a hard requirement for this in any spec, but it's a convention that makes sense.
…inition to avoid seeing commas in arrays with comments at the end. Make comments a valid end-of-dictionary-value delimiter.
Thanks for your contribution! I want to get some unit tests in this repo to ensure contributions are not breaking previous syntax highlighting features, but I have not sat down and thought about it for too long. How are you testing your changes, and what files have you tested your syntax highlighting enhancements with? |
Nice to see you're still around. Unittests would be the right approach for the CI pipeline.
|
Perfect. I'll take a peak around the space to see how others are unit testing textmate grammars, and work through some tests of at least some of the areas I was struggling with initially when releasing this. If that is delaying the PR for too long I'll do a quick visual regression test then merge. |
I've successfully automated the (comment-centric) unittests using the |
Added inline comment support. This required a bit of cleanup of existing field definitions. Tested with VS Code 1.94.2.
Issue: #10